Review Request: KAuth support in KDM kcontrol module

[Igor Krivenko]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3631/
-----------------------------------------------------------

(Updated 2010-05-10 18:33:56.307128)


Review request for kdelibs, usability, Dario Freddi, Oswald Buddenhagen, and Frederik Gladhorn.


Changes
-------

Fixes of coding style.
removeDirTree() and installDirTree() don't use QDirIterator anymore (they are now implemented as recursive functions).
More security checks (the helper will not install a non-world-readable file to avoid disclosure of sensitive information).

> do you already know whether kdm-theme will need to change once knewstuff is kauth-ified or whether it will be completely self-contained.
I'm pretty sure that no changes in kdm-theme.* will be required. At most one will have to update kdm.knsrc to specify the name of a KAuth action.

BTW, is this patch affected by the hard feature freeze coming tomorrow?


Summary
-------

This is a patch for KDM kcontrol module.
It implements Kauth support for changing kdm settings and managing user images. 
It still doesn't support installation/deletion of themes (including installation via knewstuff).
As far as I know there were plans to port KNewStuff3 to KAuth, so a more consistent approach is
to rely on the KNewStuff's integration when it's available.


Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/kcontrol/kdm/CMakeLists.txt 1125102 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/background.h 1125102 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/background.cpp 1125102 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/helper.h PRE-CREATION 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/helper.cpp PRE-CREATION 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kcmkdm_actions.actions PRE-CREATION 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-conv.h 1125102 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-conv.cpp 1125102 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-dlg.h 1125102 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-dlg.cpp 1125102 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-gen.h 1125102 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-gen.cpp 1125102 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-shut.h 1125102 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-shut.cpp 1125102 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-theme.h 1125102 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-theme.cpp 1125102 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-users.h 1125102 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-users.cpp 1125102 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/main.h 1125102 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/main.cpp 1125102 

Diff: http://reviewboard.kde.org/r/3631/diff


Testing
-------


Screenshots
-----------

Saving KDM settings
  http://reviewboard.kde.org/r/3631/s/360/
Managing user images
  http://reviewboard.kde.org/r/3631/s/361/


Thanks,

Igor