KDE Observatory applet and data engine moved to kdereview

Mon May 10 15:36:07 BST 2010

A Dimecres, 5 de maig de 2010, Sandro Andrade va escriure:
> Hi there,
> 
> KDE Observatory applet and data engine were moved to kdereview.
> 
> New features:
> - New data engine for KDE Observatory applet.
> - Performance improvements: gather data from a consolidated commit
> database instead of scanning kde-commits archives.
> - Filter reports by date range.
> - Krazy reports enhancements.
> 
> Applet:
> ----------
> Previous location: KDE/kdeplasma-addons/applets/kdeobservatory
> Review: kdereview/plasma/applets/kdeobservatory
> Final location: KDE/kdeplasma-addons/applets/kdeobservatory
> 
> Data Engine:
> ------------------
> Previous location: playground/base/plasma/dataengines/kdeobservatory
> Review: kdereview/plasma/dataengines/kdeobservatory
> Final location: KDE/kdeplasma-addons/dataengines/kdeobservatory

Your are adding strings that are going to be shown to the user. That is bad, 
examples (you have more):
  i18n("Commit History") + " - " + i.key()
  i18n("Last update: ") + QDateTime::currentDateTime().toString("dd/MM/yyyy 
hh:mm:ss")
  "<html><body><h5>" + testName + ' ' + QString::number(rank) + ' ' + 
i18np("error", "errors", rank) + "<ul>"  <-- woa for this one ;-)
  i18n("Krazy report not found: ") + QUrl::fromPercentEncoding(storedJob-
>url().prettyUrl().toUtf8())

Please use the proper %x arguments.

Also i'm concerned about the usage of QDate[Time].toString() hardcoding the 
format there, we have KLocale for that. And i can say that 
TimeScaleDraw::label raises a huge warning flag for me too.

Albert

> 
> Thanks,
> Sandro