Review Request: fixed file kioslave on windows (it was reporting non-existing files as existing)

Ilie Halip lupuroshu at gmail.com
Sun May 9 19:59:36 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3938/
-----------------------------------------------------------

(Updated 2010-05-09 18:59:35.996204)


Review request for kdelibs.


Changes
-------

wrong group :D sorry


Summary
-------

This patch fixes the problem reported here: https://bugs.kde.org/show_bug.cgi?id=207162

It was a problem that I think happened all over KDE on Windows, because the kio_file slave was reporting incorrect information (S_IFREG for non-existing files). I removed the createUDSEntryWin function, and moved FileProtocol::stat inside file.cpp, because both unix and win now have a common implementation.


This addresses bug 207162.
    https://bugs.kde.org/show_bug.cgi?id=207162


Diffs
-----

  trunk/KDE/kdelibs/kioslave/file/file.cpp 1124299 
  trunk/KDE/kdelibs/kioslave/file/file_unix.cpp 1124299 
  trunk/KDE/kdelibs/kioslave/file/file_win.cpp 1124299 

Diff: http://reviewboard.kde.org/r/3938/diff


Testing
-------

listing files in directories
saving/loading files from ktuberling with/without extension


Thanks,

Ilie





More information about the kde-core-devel mailing list