Review Request: Provide symbolic link destination as additional info in KFileItemDelegate

[Fredrik Höglund]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3912/#review5551
-----------------------------------------------------------

Ship it!


In that case I say go ahead and commit it.

- Fredrik


On 2010-05-09 11:26:17, Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3912/
> -----------------------------------------------------------
> 
> (Updated 2010-05-09 11:26:17)
> 
> 
> Review request for kdelibs, Peter Penz, Sebastian Trueg, and Fredrik Höglund.
> 
> 
> Summary
> -------
> 
> I propose to provide the destination of a symbolic link as additional information in KFileItemDelegate. This will enable us to provide that as a column in Dolphin's and Konqueror's Details View, which has been requested a couple of times (note that KDE 3 had that feature).
> 
> Like Sebastian who filed the related request http://reviewboard.kde.org/r/3354/, I think that this information may be useful outside Dolphin and should therefore be provided in KFileItemDelegate. Additionally, Dolphin currently stores the additional columns which are enabled in a KFileItemDelegate::InformationList, which means that not adding this information in KFID, but only in Dolphin itself would require a total rewrite of the code that stores the additional columns.
> 
> Any feedback is appreciated. If nobody (in particular Fredrik) objects, I'd like to commit this on Monday to make sure that we can get this feature into 4.5. I could include Sebastian's patch in my commit if there is agreement that both additions to KFID are desirable.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kio/kio/kfileitemdelegate.h 1123638 
>   /trunk/KDE/kdelibs/kio/kio/kfileitemdelegate.cpp 1123638 
> 
> Diff: http://reviewboard.kde.org/r/3912/diff
> 
> 
> Testing
> -------
> 
> I've got a patch for Dolphin that makes use of this in the Details View - works as expected for me.
> 
> 
> Thanks,
> 
> Frank
> 
>