Review Request: Port the kio file conflict dialog to KFileMetaDataWidget and PreviewJob

Todd toddrme2178 at
Sun May 9 00:39:20 BST 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-05-08 23:39:19.987568)

Review request for kdelibs, Peter Penz and David Faure.


This implements David's suggestions.  It also makes the dialog work properly for remote files, showing mimetype, size, and modified times for such files.  If worse comes to worse and that information cannot be obtained it will fall back to using the information provided to the dialog.  I also made the preview part of the scroll area to make it easier to see the file information.  

The only thing I couldn't do was eliminate the dependence on a hard-coded minimum preview size, nor did anyone seem to have any suggestions on how I could do so.  I also looked at the previous version, it was also dependent on hard-coded values so at the very least this is not a regression.  

Due to the impending hard feature freeze, if this is the only problem would it be possible to go ahead and commit this and I can resolve the preview size issue after the freeze?  I am really hoping to get this in for 4.5.  I don't have svn access, so if it ready to ship please go ahead and commit it.  Thanks a lot.


This patch switches the kio file conflict dialog (renamedialog) from using mimetype-specific plugins for previews (sometimes) and file information to instead using KFileMetaDataWidget for information and PreviewJob for previews.  

This approach has several advantages.  First, it shares code with the rest of KDE, so there is no need to write additional plugins for the renamedialog (which only has two plugins currently).  It also means that the appearance is consistent across all file types, instead of having completely different layouts for different file types.  It also allows for nepomuk information to be displayed (when available).  It allows for more information than would fit comfortably (using scroll bars).  And finally it allows for previews and specialized information of file types for which writing now plugins would be a waste of time (like text files and folders).  

As far as I can tell it should be backwards-compatible (if it isn't I'll fix it).  Using this approach does mean that renamedialogplugin (which I left alone for compatibility) does not actually do anything anymore.  However, the new widget provides more information and provides it for more file types than the plugins.

It does not give previews for videos, but the existing rename dialog doesn't either so there is nothing lost there.  PhononWidget handles this in Dolphin, but since it is part of dolphin it is not available in kdelibs

Diffs (updated)

  /trunk/KDE/kdelibs/kio/kio/renamedialog.h 1124353 
  /trunk/KDE/kdelibs/kio/kio/renamedialog.cpp 1124353 



It gives proper previews for images and text files, and proper icons for folders and unknown binary files.  It also gives the correct icon for video files, but no preview (which is the same as the old widget).

This is a complete rewrite of a large portion of the dialog, so I would very much appreciate it if other people tested it as well.



More information about the kde-core-devel mailing list