New dependency for kdelibs and kdebase: dbusmenu-qt

[Alexander Neundorf]

On Friday 07 May 2010, Modestas Vainius wrote:
> Hello,
>
> On šeštadienis 08 Gegužė 2010 00:11:07 Alexander Neundorf wrote:
> > Ok, now I actually tested it.
> > Please try the attached example yourself.
> > It links an executable with one library in /lib/, one in /usr/lib/, one
> > in /usr/local/lib/, and one in /opt/kdelibs/lib/, with
> > INSTALL_RPATH_USE_LINK_PATH enabled.
> >
> > Resulting RPATHS in the installed executable:
> > cmake 2.4.5: /opt/kdelibs/lib:/usr/local/lib:/lib
> > cmake 2.6.2: /opt/kdelibs/lib:/usr/local/lib
> > cmake 2.8.1: /opt/kdelibs/lib:/usr/local/lib
> >
> > cmake 2.8.1 with /usr/local/lib added to
> > CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES in
> > Modules/Platform/UnixPath.cmake: /opt/kdelibs/lib
> >
> > So the directories listed in CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES are
> > not added to the RPATH by cmake.
>
> Well ok, so cmake is smart enough for INSTALL_RPATH_USE_LINK_PATH.
> Apparently, INSTALL_RPATH_USE_LINK_PATH is ok to enabled by default.
>
> But the problem is that KDE sets CMAKE_INSTALL_RPATH / INSTALL_RPATH
> manually in numerous places as well. For example, the following propagates
> this bad practise to all KDE applications:
>
> http://websvn.kde.org/trunk/KDE/kdelibs/cmake/modules/FindKDE4Internal.cmak
>e?view=markup
>
> line 998.

Ok, I added the CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES-checking there now in 
r1124215.

> So those CMAKE_INSTALL_RPATH are what I had to patch out mostly. 

Are you aware of other places ?
In trunk/KDE/ this *should* be the only place where the RPATH is set.

> Basically,
> grepping for CMAKE_INSTALL_RPATH and INSTALL_RPATH target property would
> reveal all evil cases. However, I have a feeling they are redundant even in
> your setup when INSTALL_RPATH_USE_LINK_PATH is in effect?

No.
It doesn't add the RPATH to the libraries which are installed with the same 
project, "only" all others.
I think I'll file a feature request for that.

Alex