Review Request: Route (un)mounting errors via knotify to the plasma device notifier with fallback to regular notifications

Jacopo De Simoi wilderkde at
Thu May 6 22:15:15 BST 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-05-06 21:15:15.179530)

Review request for kdelibs, Aaron Seigo, Marco Martin, and Olivier Goffart.


Fixed style and svn added the file hardwarenotifications.notifyrc which I forgot before :)

Olivier, your observation about dbus is indeed correct:
we need to invert the instantiation of the watcher and the first check. In fact the same patch should be applied to 
notifybypopup.cpp, from which I took the code logic.

Better to patch the two files at once?


This patch adds a solid device watcher to knotify; the class watches for errors and sends them either to a dbus interface (offered by 
a plasma dataengine) or, if the interface is not found, thru regular notifications.

Diffs (updated)

  trunk/KDE/kdebase/runtime/knotify/CMakeLists.txt 1121868 
  trunk/KDE/kdebase/runtime/knotify/hardwarenotifications.notifyrc PRE-CREATION 
  trunk/KDE/kdebase/runtime/knotify/knotify.cpp 1121868 
  trunk/KDE/kdebase/runtime/knotify/ksolidnotify.h PRE-CREATION 
  trunk/KDE/kdebase/runtime/knotify/ksolidnotify.cpp PRE-CREATION 



It needs a patch to plasma to work properly, will file that soon to the revboard.

With that patch, it works well.



More information about the kde-core-devel mailing list