Review Request: KAuth support in KDM kcontrol module

[Oswald Buddenhagen]

> On 2010-05-03 21:37:39, Oswald Buddenhagen wrote:
> > hmm, you have a point here. i don't like entirely removing the feature, so option 3 would be best for now.
> > now you have the option to duplicate the respective string in each call as you had it before or duplicate the whole function. i think i'd go for the latter in this case, as the function is quite short and the gained legibility of the code is worth it. but the functions should get more descriptive names, like executeFaceAction() and executeThemeAction() or something like that.
> 
> Frederik Gladhorn wrote:
>     Yes, I'm sorry that the kauth isn't yet there in knewstuff. The installation of things is a bit ugly, because knewstuff supports quite a few different settings.
>     I started towards this (cleaning up and streamlining some very old code) but I can't promise that it will be finished soon. On the other hand, if I get the cleaning done, it will be just one place where the downloaded files are moved to their destination, so introducing kauth there would be easy enough (but I'll be gone until next weekend).

you don't have to apologize for that - i don't think you committed to anything. ;)
i'm not sure you fully understood what this subthread is about, though. kcm_kdm has a local installation facility which predates knewstuff (essentially, just unpacking a tar to the right place), so even if you add kauth support to knewstuff, this would still need separate support (which igor has done now). unless you consider to add such a "local escape path" to the library (or is it there already?), this is nothing you need to worry about. :)


- Oswald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3631/#review5381
-----------------------------------------------------------


On 2010-05-05 20:08:34, Igor Krivenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3631/
> -----------------------------------------------------------
> 
> (Updated 2010-05-05 20:08:34)
> 
> 
> Review request for kdelibs, usability, Dario Freddi, Oswald Buddenhagen, and Frederik Gladhorn.
> 
> 
> Summary
> -------
> 
> This is a patch for KDM kcontrol module.
> It implements Kauth support for changing kdm settings and managing user images. 
> It still doesn't support installation/deletion of themes (including installation via knewstuff).
> As far as I know there were plans to port KNewStuff3 to KAuth, so a more consistent approach is
> to rely on the KNewStuff's integration when it's available.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/CMakeLists.txt 1121893 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/background.h 1121893 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/background.cpp 1121893 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/helper.h PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/helper.cpp PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kcmkdm_actions.actions PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-conv.h 1121893 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-conv.cpp 1121893 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-dlg.h 1121893 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-dlg.cpp 1121893 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-gen.h 1121893 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-gen.cpp 1121893 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-shut.h 1121893 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-shut.cpp 1121893 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-theme.h 1121893 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-theme.cpp 1121893 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-users.h 1121893 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-users.cpp 1121893 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/main.h 1121893 
>   /trunk/KDE/kdebase/workspace/kcontrol/kdm/main.cpp 1121893 
> 
> Diff: http://reviewboard.kde.org/r/3631/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Saving KDM settings
>   http://reviewboard.kde.org/r/3631/s/360/
> Managing user images
>   http://reviewboard.kde.org/r/3631/s/361/
> 
> 
> Thanks,
> 
> Igor
> 
>