Review Request: KAssistantDialog needs to enable/disable back/next/finished buttons after setAppropriate() is called

Michael Hancock javaiscoolmike at
Wed May 5 13:48:23 BST 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-05-05 12:48:23.333309)

Review request for kdelibs and Olivier Goffart.


I changed the method's name to updateButtons() as was suggested by Christoph Feck.


KAssistantDialog currently does not disable/enable the back/next/finished buttons as needed after setAppropriate() is called.  This is needed if the current page sets all of the pages after it to be 'inappropriate', or if it sets all of the previous pages to be 'inappropriate' (though I don't think this case would ever really be used).  I also renamed the method _k_slotCurrentPageChanged() to _k_slotUpdateBackNextFinishedButtons(), since this function is called for more then just the situation where the current page has changed.  This my first time to submit a patch ever (yea, I know this is a pretty small patch), so I would like any feed back I can get. :)

Diffs (updated)

  /trunk/KDE/kdelibs/kdeui/dialogs/kassistantdialog.h 1122770 
  /trunk/KDE/kdelibs/kdeui/dialogs/kassistantdialog.cpp 1122770 



I tested this patch with current kde trunk, and it worked with the kde program I am currently working on (a small program am writing to familiarize my self with KDE development).  With this patch the next/finished buttons now get enabled/disabled after my second page calls setAppropriate() on the pages after it.  I can create a more 'propper' smaller test program if needed. let me know.  



More information about the kde-core-devel mailing list