Review Request: Route (un)mounting errors via knotify to the plasma device notifier with fallback to regular notifications
Jacopo De Simoi
wilderkde at gmail.com
Wed May 5 17:00:58 BST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3895/
-----------------------------------------------------------
Review request for kdelibs, Aaron Seigo, Marco Martin, and Olivier Goffart.
Summary
-------
This patch adds a solid device watcher to knotify; the class watches for errors and sends them either to a dbus interface (offered by
a plasma dataengine) or, if the interface is not found, thru regular notifications.
Diffs
-----
trunk/KDE/kdebase/runtime/knotify/CMakeLists.txt 1121868
trunk/KDE/kdebase/runtime/knotify/knotify.cpp 1121868
trunk/KDE/kdebase/runtime/knotify/ksolidnotify.h PRE-CREATION
trunk/KDE/kdebase/runtime/knotify/ksolidnotify.cpp PRE-CREATION
Diff: http://reviewboard.kde.org/r/3895/diff
Testing
-------
It needs a patch to plasma to work properly, will file that soon to the revboard.
With that patch, it works well.
Thanks,
Jacopo
More information about the kde-core-devel
mailing list