New dependency for kdelibs and kdebase: dbusmenu-qt

[Alexander Neundorf]

On Tuesday 04 May 2010, Maksim Orlovich wrote:
> > Hi,
> >
> > I just committed support for DBusMenu in kdelibs and kdebase.
> >
> > - In kdelibs, DBusMenu is used by KStatusNotifierItem to export their
> > menus over DBus.
> > - In kdebase, DBusMenu is used by the Plasma SystemTray applet to render
> > the KStatusNotifierItem menus.
> >
> > The advantage of this new system is that the visualisation gets more
> > control over the rendering of its items, compared to the previous
> > implementation which asked the application to show their menu at a give
> > position.
> >
> > It is also nice for users of libappindicator-enabled [1] GNOME
> > applications, because the SystemTray menus of these applications will be
> > rendered using a native KDE menu.
> >
> > This means to build kdelibs and kdebase you now need to install
> > dbusmenu-qt. dbusmenu-qt tarballs are available here:
> >
> >    http://people.canonical.com/~agateau/dbusmenu/
>
> Would something like this be acceptable?
>
> --- modules/FindDBusMenuQt.cmake        (revision 1122815)
> +++ modules/FindDBusMenuQt.cmake        (working copy)
> @@ -31,6 +31,6 @@
>      PATH_SUFFIXES dbusmenu-qt
>      )
>
> -find_package_handle_standard_args(DBusMenuQt DEFAULT_MSG
> DBUSMENUQT_LIBRARIES DBUSMENUQT_INCLUDE_DIR)
> +find_package_handle_standard_args(DBusMenuQt "Could not find dbusmenu-qt;
> available at http://people.canonical.com/~agateau/dbusmenu/"
> DBUSMENUQT_LIBRARIES DBUSMENUQT_INCLUDE_DIR)
>
>  mark_as_advanced(DBUSMENUQT_INCLUDE_DIR DBUSMENUQT_LIBRARIES)


Yes.

Alex