Review Request: KWidgetItemDelegate crashed for KTorrent

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3874/#review5364
-----------------------------------------------------------

Ship it!


Looks fine to me.

- Kevin


On 2010-05-03 06:38:41, Frederik Gladhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3874/
> -----------------------------------------------------------
> 
> (Updated 2010-05-03 06:38:41)
> 
> 
> Review request for kdelibs, Kevin Ottens and Rafael Fernández López.
> 
> 
> Summary
> -------
> 
> ktorrent uses kwidgetitemdelegate in a way that broke with making it possible to delete the delegate without simultanously removing the view.
> It passes the view as parent and view into KWidgetItemDelegate(QAbstractItemView *itemView, QObject *parent = 0).
> When the view is deleted, the delegate will be deleted in the qobject destructor that deletes the view children. This leads to double deletion of the widgets created by kwidgetitemdelegate, since they are reparented by the view.
> This patch makes ktorrent work again. (bug 233783)
> 
> 
> This addresses bug 233783.
>     https://bugs.kde.org/show_bug.cgi?id=233783
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegatepool.cpp 1121890 
>   trunk/KDE/kdelibs/kdeui/itemviews/kwidgetitemdelegatepool_p.h 1121890 
> 
> Diff: http://reviewboard.kde.org/r/3874/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frederik
> 
>