Soft Feature Freeze: fixing crashes by rewriting parts of the code

Andreas Pakulat apaku at gmx.de
Sun May 2 17:28:15 BST 2010


On 02.05.10 18:00:31, Nick Shaforostoff wrote:
> Hi everybody.
> 
> I've got a crash report, which tells me that Lokalize may corrupt glossary.
> https://bugs.kde.org/show_bug.cgi?id=228459
> 
> This is because of a bad code design. I used SAX API for XML manipulation and 
> obviously got it messed up.
> 
> I started rewriting glossary storage classes to use DOM API a ~month ago.
> Now it is finished. I tested features like deleting entries, adding entries, 
> changing term lists. The new code is more OOP-friendly and cleaner.
> 
> May I commit the patch to trunk now?
> 
> The patch is attached.

Just wanted to note that QDom* is basically unmaintained by now, Nokia
won't do anything to anymore and they're suggesting to users of the
class to switch to something else (like the QXmlStream* classes).

Andreas

-- 
You prefer the company of the opposite sex, but are well liked by your own.




More information about the kde-core-devel mailing list