Soft Feature Freeze: fixing crashes by rewriting parts of the code

Nick Shaforostoff shafff at ukr.net
Sun May 2 16:00:31 BST 2010


Hi everybody.

I've got a crash report, which tells me that Lokalize may corrupt glossary.
https://bugs.kde.org/show_bug.cgi?id=228459

This is because of a bad code design. I used SAX API for XML manipulation and 
obviously got it messed up.

I started rewriting glossary storage classes to use DOM API a ~month ago.
Now it is finished. I tested features like deleting entries, adding entries, 
changing term lists. The new code is more OOP-friendly and cleaner.

May I commit the patch to trunk now?

The patch is attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: glossary-rewrite.patch.gz
Type: application/x-gzip
Size: 13981 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100502/bc6b0fd0/attachment.bin>


More information about the kde-core-devel mailing list