Review Request: Add a confirmation window when emptying the trash

[Nicolas Lécureuil]

> On 2010-03-30 22:41:25, Gaurish Sharma wrote:
> > users might hit "empty trash" by mistake, while they in fact were looking for how to get stuff out of the trash. Since there's no undo for this operation, a confirmation doesn't sound like a bad idea;
> > 
> > +1
> > Exactly My Thoughts! Infact same thing has happened with me before.
> > I needed to restore some needed files from Trash, so I Right-clicked looking check "Properties" by I clicked on "Empty Trash" by mistake. 
> > I was expecting a Confirmation but nothing came.
> > 
> > I lost my data :-( 
> > 
> > THIS SHOULD BE IMPLEMENTED

this is now in trunk for next kde 4.5

thanks


- Nicolas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3434/#review4806
-----------------------------------------------------------


On 2010-03-30 14:43:52, Nicolas Lécureuil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3434/
> -----------------------------------------------------------
> 
> (Updated 2010-03-30 14:43:52)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> When the user empty the trash ( when using trash:/ in a desktop file ) there is no confirmation window.
> This patch add a confirmation window.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kio/kio/jobuidelegate.cpp 1108647 
>   /trunk/KDE/kdelibs/kio/kio/jobuidelegate.h 1108647 
>   /trunk/KDE/kdebase/apps/lib/konq/konq_operations.cpp 1108647 
> 
> Diff: http://reviewboard.kde.org/r/3434/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas
> 
>