Review Request: kdesupport/cpptoxml krazy fixes: Check for compares to QString::null or QString().

Glen Kaukola gkaukola at cs.ucr.edu
Tue Mar 30 06:35:11 BST 2010



> On 2010-03-29 18:39:39, Pieter Vande Wyngaerde wrote:
> > how can ==QString() and !=QString() both translate to .isEmpty()  ?
> 
> Raphael Kubo da Costa wrote:
>     Damn, you're right.

Sorry, I blew it.  Things should be good now though.


- Glen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3424/#review4749
-----------------------------------------------------------


On 2010-03-30 05:34:27, Glen Kaukola wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3424/
> -----------------------------------------------------------
> 
> (Updated 2010-03-30 05:34:27)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> kdesupport/cpptoxml krazy fixes: Check for compares to QString::null or QString().
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/cpptoxml/main.cpp 1107607 
> 
> Diff: http://reviewboard.kde.org/r/3424/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Glen
> 
>





More information about the kde-core-devel mailing list