Review Request: Improve KColorChooser dialog color preset selection implementing a custom ItemDelegate

Ingo Klöcker kloecker at kde.org
Sun Mar 28 10:42:16 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3410/#review4710
-----------------------------------------------------------


IMO it looks better just with the circle. The dot hides even more of the actual color and thus works against the intention of this patch.

Another idea might be to make the selected color look like a pressed button, i.e. add a "sunken shadow" to the selected color.

- Ingo


On 2010-03-27 20:24:13, Darío Andrés wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3410/
> -----------------------------------------------------------
> 
> (Updated 2010-03-27 20:24:13)
> 
> 
> Review request for kdelibs and usability.
> 
> 
> Summary
> -------
> 
> Do not use the QPalette::Highlight color to show the selected color preset in the KColorChooser dialog. 
> 
> Use a custom selection drawing, black or white (depending on the contrast with the original color (KColorUtils::constrastRatio > 3.5))
> This way you get a "this color is selected" hint, but you are still able to see which color it was/is
> 
> My last choice was a centered empty circle. Drawing a rectangle (or dotted rectangle) had too much glitches as the color preset buttons in the tableview are small (~ 13x13 pixels)
> Also, there is a bug (not caused by me) that reduces the color preset buttons height or width (by one) on the top/left borders (seems to be related to the QTableWidget without Headers..)
> 
> I tried to not use color shading as it is still confusing to the user...
> 
> As a gift, I added a small detail in the empty buttons (no color defined), drawing a cross on it (using the background color)
> 
> Attached screenshot: can you recognize the selected color in the first one ? (hint: the same color is selected in both screenies..)
> 
> 
> This addresses bug 230524.
>     https://bugs.kde.org/show_bug.cgi?id=230524
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/colors/kcolordialog.cpp 1107102 
> 
> Diff: http://reviewboard.kde.org/r/3410/diff
> 
> 
> Testing
> -------
> 
> It works Ok and it looks good (ok, it could be prettier, any ideas? may be a gradient?)
> At least it doesn't block the real color.
> 
> 
> Screenshots
> -----------
> 
> Before and After my patch
>   http://reviewboard.kde.org/r/3410/s/340/
> With a radiobutton-like selection
>   http://reviewboard.kde.org/r/3410/s/341/
> 
> 
> Thanks,
> 
> Darío
> 
>





More information about the kde-core-devel mailing list