Review Request: KPixmapRegionSelectorDialog fix: Enforce maximum size in the selector widget to not overflow the screen size
Darío Andrés
andresbajotierra at gmail.com
Sat Mar 27 20:00:23 GMT 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3413/
-----------------------------------------------------------
Review request for kdelibs.
Summary
-------
- Remove some code duplication
- Enforce the maximum width/height on the KPixmapRegionSelectorWidget, so the dialog doesn't overflow the screen size
I had also to fix some code on KPixmapRegionSelectorWidget, otherwise it would create a false selection (when there were none) after the rotation.
Additions: centering the dialog in the screen after the rotation could be useful (specially for some rectangle images)
The name of the functions and/or the apidox could be improved...
This addresses bug 227659.
https://bugs.kde.org/show_bug.cgi?id=227659
Diffs
-----
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/dialogs/kpixmapregionselectordialog.h 1107102
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/dialogs/kpixmapregionselectordialog.cpp 1107102
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/widgets/kpixmapregionselectorwidget.h 1107102
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/widgets/kpixmapregionselectorwidget.cpp 1107102
Diff: http://reviewboard.kde.org/r/3413/diff
Testing
-------
The dialog works OK, the resize is done properly and the dialog size remains the same.
I'm not really sure if my approach of "Slots inside a private class" is OK.... Could someone check it ?
Thanks,
Darío
More information about the kde-core-devel
mailing list