Review Request: KPixmapRegionSelectorDialog fix: Enforce maximum size in the selector widget to not overflow the screen size

Darío Andrés andresbajotierra at
Sat Mar 27 20:00:23 GMT 2010

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs.


- Remove some code duplication
- Enforce the maximum width/height on the KPixmapRegionSelectorWidget, so the dialog doesn't overflow the screen size

I had also to fix some code on KPixmapRegionSelectorWidget, otherwise it would create a false selection (when there were none) after the rotation.

Additions: centering the dialog in the screen after the rotation could be useful (specially for some rectangle images)

The name of the functions and/or the apidox could be improved...

This addresses bug 227659.


  svn:// 1107102 
  svn:// 1107102 
  svn:// 1107102 
  svn:// 1107102 



The dialog works OK, the resize is done properly and the dialog size remains the same.

I'm not really sure if my approach of "Slots inside a private class" is OK.... Could someone check it ?



More information about the kde-core-devel mailing list