[PATCH] Update KAboutData after KApplication instance has been created

Aaron J. Seigo aseigo at kde.org
Thu Mar 25 15:56:08 GMT 2010

On March 24, 2010, Rafael Fernández López wrote:
> creates the about widget only when necessary. Basically it was that
> KComponentData was "caching" it as an instance, so changing the
> KAboutData afterwards (the instance you created on main.cpp) had no
> effect since it had been already cached.

why not just add a KComponentData::setAboutData(const KAboutData &about)?

(and yes, as Johannes notes, taking the address of an object passed by 
reference is rather dangerous)

> So, what do you think about the attached patch ? I would give a week
> to leave comments, and next wednesday I'd commit this into trunk.
> Another question: do you think I should backport this change ?

imho no; api changes shouldn't be backported unless they actually fix an 
important bug.

Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks

More information about the kde-core-devel mailing list