Review Request: Add KMetaDataWidget, KMetaDataModel and KMetaDataConfigurationDialog

Peter Penz peter.penz at
Mon Mar 22 18:02:40 GMT 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-03-22 18:02:40.025826)

Review request for kdelibs, Sebastian Trueg, David Faure, and Aurélien Gâteau.


Another update of the patch:
- Renamed class KMetaDataWidget to KFileMetaDataWidget as suggested by Sebastian and Aurélien.
- Renamed the (internal) class KMetaDataModel to KFileMetaDataProvider.
- Renamed the (marked as internal) class KMetaDataConfigurationDialog to KFileMetaDataConfigurationDialog.

As the BIC-Monday timeframe has only a few hours left: I think there is a common sense after the reviews that the metadata widget in principal should go into kdelibs. So if nobody objects, I'll commit the patch today.

Of course I'll take care for further comments and suggestions and will do updates on the next BIC-Mondays if required.


The patch adds KMetaDataWidget, KMetaDataModel and KMetaDataConfigurationDialog as public classes to kdelibs/kfile. The KMetaDataWidget allows an application in an easy way to show meta data of a file (or several files). The widget also allows to change meta data like tags, comments and rating (see or attached screenshot). KMetaDataConfigurationDialog allows to configure which meta tags should be hidden/shown. The classes also work without Nepomuk (and show only very basic meta data like size, permissions, ...). It is possible for applications to add custom meta data if wanted (including widgets to manipulate this meta data).

The classes have been used by Dolphin internally until now and have originally been written by Sebastian Trüg. After the request from Tom Albers and Oliver Heidbüchel to integrate the widget also in Mailody/Okular I've adjusted the classes to get them ready for a kdelibs-integration. I'd also like to to adjust KPropertiesDialog later to use this widget.

I'd ask mainly to look at the files kfile/kmetadatawidget.h, kfile/kmetadatamodel.h and kfile/kmetadataconfigurationdialog.h, the other APIs are internal.


Diffs (updated)

  trunk/KDE/kdelibs/CMakeLists.txt 1106199 
  trunk/KDE/kdelibs/config-nepomuk.h.cmake PRE-CREATION 
  trunk/KDE/kdelibs/kfile/CMakeLists.txt 1106199 
  trunk/KDE/kdelibs/kfile/kcommentwidget.cpp PRE-CREATION 
  trunk/KDE/kdelibs/kfile/kcommentwidget_p.h PRE-CREATION 
  trunk/KDE/kdelibs/kfile/kedittagsdialog.cpp PRE-CREATION 
  trunk/KDE/kdelibs/kfile/kedittagsdialog_p.h PRE-CREATION 
  trunk/KDE/kdelibs/kfile/kfilemetadataconfigurationdialog.h PRE-CREATION 
  trunk/KDE/kdelibs/kfile/kfilemetadataconfigurationdialog.cpp PRE-CREATION 
  trunk/KDE/kdelibs/kfile/kfilemetadataprovider.cpp PRE-CREATION 
  trunk/KDE/kdelibs/kfile/kfilemetadataprovider_p.h PRE-CREATION 
  trunk/KDE/kdelibs/kfile/kfilemetadatawidget.h PRE-CREATION 
  trunk/KDE/kdelibs/kfile/kfilemetadatawidget.cpp PRE-CREATION 
  trunk/KDE/kdelibs/kfile/kloadfilemetadatathread.cpp PRE-CREATION 
  trunk/KDE/kdelibs/kfile/kloadfilemetadatathread_p.h PRE-CREATION 
  trunk/KDE/kdelibs/kfile/knfotranslator.cpp PRE-CREATION 
  trunk/KDE/kdelibs/kfile/knfotranslator_p.h PRE-CREATION 
  trunk/KDE/kdelibs/kfile/ktaggingwidget.cpp PRE-CREATION 
  trunk/KDE/kdelibs/kfile/ktaggingwidget_p.h PRE-CREATION 
  trunk/KDE/kdelibs/nepomuk/core/ui/CMakeLists.txt 1106199 
  trunk/KDE/kdelibs/nepomuk/core/ui/nepomukmassupdatejob.h 1106199 
  trunk/KDE/kdelibs/nepomuk/core/ui/nepomukmassupdatejob.cpp 1106199 



Tested in Dolphin. An early version has been tested also in Mailody and Okular.





More information about the kde-core-devel mailing list