Review Request: 4.5 Feature: FictionBook Thumbnails

[Harsh J]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3272/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

This feature addition to kdebase aims to provide thumbnails of FictionBook covers.

Early-message: This is my first try at XML parsing (I've used the SAX approach), so do give me pointers/tips on doing it better wherever possible :-)

I've written code to:
  * Parse the FB2 XML file.
  * Get the 'image' element under the 'coverpage' element, and get its ID.
  * Find a 'binary' element with the same ID and save its character data.
  * Convert this base64 data to a QImage and load it as the thumb.

References I used:
  * The FictionBook format spec: http://gribuser.ru/xml/fictionbook/2.0/xsd/FictionBook2.xsd
  * Some .fb2 files (russian ones are all I could find) at http://fictionbook.ru

Feature entry has also been added to the 4.5 Feature Plan (ePub thumbnails are also put up on for reviewing)

P.s. Shall I also commit this to /trunk/kdereview?


Diffs
-----

  /trunk/KDE/kdebase/runtime/kioslave/thumbnail/CMakeLists.txt 1102437 
  /trunk/KDE/kdebase/runtime/kioslave/thumbnail/fictionbookcreator.h PRE-CREATION 
  /trunk/KDE/kdebase/runtime/kioslave/thumbnail/fictionbookcreator.cpp PRE-CREATION 
  /trunk/KDE/kdebase/runtime/kioslave/thumbnail/fictionbookthumbnail.desktop PRE-CREATION 

Diff: http://reviewboard.kde.org/r/3272/diff


Testing
-------

Tested with a random sample of files at http://fictionbook.ru


Screenshots
-----------

FictionBook Previews in Dolphin File Manager
  http://reviewboard.kde.org/r/3272/s/329/


Thanks,

Harsh