Review Request: Should automatically assign an accelerator to a checkable group box

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3084/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

The automatic assignment of accelerators to widgets does not assign a shortcut to
a checkable group box.  For a standard group box an accelerator is indeed pointless,
but it is useful for a checkable group box to allow keyboard interaction (it can be
considered equivalent to a QCheckBox).


This addresses bug 229135.
    https://bugs.kde.org/show_bug.cgi?id=229135


Diffs
-----

  /trunk/KDE/kdelibs/kdeui/shortcuts/kacceleratormanager.cpp 1091671 
  /trunk/KDE/kdelibs/kdeui/shortcuts/kacceleratormanager_private.h 1091671 

Diff: http://reviewboard.kde.org/r/3084/diff


Testing
-------

Checked with these changes against my application (KDE4 port of Kooka) which uses a
number of normal and checkable group boxes with no existing accelerators defined.
Checkable boxes are assigned an accelerator, whereas the normal ones are left alone.

Also checked against Konqueror's preferences (which already has some non-checkable group
boxes with explicit accelerators, these are left alone) and systemsettings.


Thanks,

Jonathan