Review Request: Remove obsolete kbuildsycoca run on startup

Sebastian Sauer mail at dipe.org
Mon Mar 1 00:32:08 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3076/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

During startup kded does emit a kbuildsycoca::notifyDatabaseChanged dbus-signal even if not needed cause kbuildsycoca will be called in Kded::recreate already.

This code went through an interesting history. It seems every famous developer in KDE touched that few lines already and they got introduced with:

r56149 | dfaure | 2000-07-11 20:13:51 +0200 (Tue, 11 Jul 2000) | 5 lines
Send the databaseChanged signal at the end of kded, unconditionnally.
Apparently, the one sent by kbuildsycoca is lost in the nature because
dcop is currently used by kdeinit... This fixes the splash screen
not being removed, on the first startup.

So, its a personal honor for me to remove that obsolete lines again :)


Diffs
-----

  /trunk/KDE/kdelibs/kded/kded.cpp 1094524 

Diff: http://reviewboard.kde.org/r/3076/diff


Testing
-------


Thanks,

Sebastian





More information about the kde-core-devel mailing list