DefineGroups getting lost after switching KParts

[Thomas Friedrichsmeier]

Hi,

On Wednesday 30 June 2010, David Faure wrote:
> I should dig further into this, but strangely enough it seems to match an
> untested patch I had lying around, maybe you want to test it?

your patch does not affect the problem. In fact, while debugging, I had even 
tried changing isEmptyContainer() to return true, unconditionally, but to no 
avail.

Anyway, as I wrote in the follow-up to myself, the problem was that several of 
my ui.rc-files used the same "client name". I would assume it is this code in 
ContainerNode::destruct(), which was then effectively purging the DefineGroups.

    // remove all merging indices the client defined
    QMutableListIterator<MergingIndex> cmIt = mergingIndices;
    while ( cmIt.hasNext() )
        if ( cmIt.next().clientName == state.clientName )
            cmIt.remove();

> If this doesn't help I'll make a note to look further into this issue.

Again, to me it remains a bit mysterious, why this used to work prior to 
commit #912265, but I do have a solution, now.

Probably duplicate client names were never meant to be supported in the first 
place, and thus it may not be worth "fixing" in the library. One thing that 
would be nice, would be to get a debug-message, when adding a client with a 
name that is already in use. But I am not sure, where this would best be 
added.

Something entirely unrelated: Could you please take a look at 
http://reviewboard.kde.org/r/4126/? I think that one is pretty important.

Regards
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100630/5f9e14d5/attachment.sig>