Review Request: Fix crash in KFileItemDelegate::paint()

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4416/#review6218
-----------------------------------------------------------

Ship it!


good catch!

- Aaron


On 2010-06-20 17:02:57, Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4416/
> -----------------------------------------------------------
> 
> (Updated 2010-06-20 17:02:57)
> 
> 
> Review request for kdelibs, Shaun Reich and Jonathan Thomas.
> 
> 
> Summary
> -------
> 
> KFileItemDelegate::paint() calls iconPosition(), which calls subtractMargin(), which requires d->activeMargins to be a valid pointer. This causes the 3rd party QuickAccess Plasma applet to crash.
> 
> Calling setActiveMargins() earlier in paint() fixes the bug.
> 
> 
> This addresses bug 241458.
>     https://bugs.kde.org/show_bug.cgi?id=241458
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kio/kio/kfileitemdelegate.cpp 1140317 
> 
> Diff: http://reviewboard.kde.org/r/4416/diff
> 
> 
> Testing
> -------
> 
> - Applet does not crash anymore.
> - Checked other applications using KFileItemDelegate, didn't notice anything wrong.
> 
> 
> Thanks,
> 
> Aurélien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100621/5e5f6ae9/attachment.htm>