Review Request: Do not fallback to Hicolor when Oxygen provides a "-x-generic" version of an icon

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4403/
-----------------------------------------------------------

Review request for kdelibs and Rafael Fernández López.


Summary
-------

When loading an icon for video-mp4, KIconLoader incorrectly returns "video.png" from Hicolor, instead of returning "video-x-generic.png" from Oxygen. Since Hicolor only has a 16x16 version, this results in blurry icons in Dolphin or Gwenview when icons are bigger than 16x16.

This is because the current code fallbacks to Hicolor before looking for a "-x-generic" version.


Diffs
-----

  trunk/KDE/kdelibs/kdeui/icons/kiconloader.cpp 1140302 
  trunk/KDE/kdelibs/kdeui/tests/kiconloader_unittest.cpp 1140302 

Diff: http://reviewboard.kde.org/r/4403/diff


Testing
-------

- Added a unit-test entry to check we get video-x-generic.
- Icons are no longer blurry after the patch.


Thanks,

Aurélien

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100620/c9ee30dd/attachment.htm>