Review Request: Do not fallback to Hicolor when Oxygen provides a "-x-generic" version of an icon

Aurélien Gâteau agateau at
Sun Jun 20 10:18:38 BST 2010

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs and Rafael Fernández López.


When loading an icon for video-mp4, KIconLoader incorrectly returns "video.png" from Hicolor, instead of returning "video-x-generic.png" from Oxygen. Since Hicolor only has a 16x16 version, this results in blurry icons in Dolphin or Gwenview when icons are bigger than 16x16.

This is because the current code fallbacks to Hicolor before looking for a "-x-generic" version.


  trunk/KDE/kdelibs/kdeui/icons/kiconloader.cpp 1140302 
  trunk/KDE/kdelibs/kdeui/tests/kiconloader_unittest.cpp 1140302 



- Added a unit-test entry to check we get video-x-generic.
- Icons are no longer blurry after the patch.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list