Review Request: Adding "net usershare" suport for KSambaShare

[Pino Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4320/#review6138
-----------------------------------------------------------


The patch mixes various changes, either the actual changes declared but a lot of unrelated changes like:
- white space removal
- indentation fixes
- the renaming of the "d" pointer to "d_ptr", which is unuseful
- the addition of an unused q_ptr in the private class (also, if public class deletes the d_ptr and the private class deletes the q_ptr, that means an happy crash)

Please limit yourself just to the actual changes.

- Pino


On 2010-06-15 20:19:09, Rodrigo Belem wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4320/
> -----------------------------------------------------------
> 
> (Updated 2010-06-15 20:19:09)
> 
> 
> Review request for kdelibs, Aurélien Gâteau, Jonathan Riddell, and Adenilson Cavalcanti.
> 
> 
> Summary
> -------
> 
> KDE needs to support modern samba tools. With the "net usershare" command line tool the users can manage their shares. The attached patch intends to add support for this tool.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kio/kio/ksambashare.h 1137974 
>   /trunk/KDE/kdelibs/kio/kio/ksambashare.cpp 1137974 
> 
> Diff: http://reviewboard.kde.org/r/4320/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rodrigo
> 
>