Review Request: document KUniqueApplication::loadCommandLineOptionsForNewInstance and implement stub

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4278/#review6099
-----------------------------------------------------------



trunk/KDE/kdelibs/kdeui/kernel/kuniqueapplication.h
<http://reviewboard.kde.org/r/4278/#comment5689>

    I don't think we should document it. The comment in the .cpp file says it is there to support Kontact, and I fail to see a reason why other applications would need this kludge.
    
    At least remove the "virtual" from the comment.


- Christoph


On 2010-06-12 06:00:15, argonel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4278/
> -----------------------------------------------------------
> 
> (Updated 2010-06-12 06:00:15)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Adds a stub version of loadCommandLineOptionsForNewInstance to squelch the new warning in QT4.7.
> 
> 
> This addresses bug 241435.
>     https://bugs.kde.org/show_bug.cgi?id=241435
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdeui/kernel/kuniqueapplication.h 1128365 
>   trunk/KDE/kdelibs/kdeui/kernel/kuniqueapplication.cpp 1128365 
> 
> Diff: http://reviewboard.kde.org/r/4278/diff
> 
> 
> Testing
> -------
> 
> Doxygen doesn't produce output yet, I'll get to the bottom of that eventually.
> 
> 
> Thanks,
> 
> argonel
> 
>