Review Request: Make KUriFilter viable for apps that only want to do search filtering...

[Andrea Diamantini]

> On 2010-06-10 22:19:46, Andrea Diamantini wrote:
> > Just one little think: in rekonq we need to know also what is the separator (space/colon). Can be simple get function be added?
> 
> Dawit Alemayehu wrote:
>     Done, but if I may ask why do you need to know the separator ?
> 
> Andrea Diamantini wrote:
>     Yes :)
>     We use it to provide url suggestions while user is typing, to guess what he/she is going to. There is a first implementation of this in rekonq 0.5.
>     Many thanks for.
> 
> Dawit Alemayehu wrote:
>     Right, but why would you need the separator for your use case was my actual question. :) Are you doing similar things as the Plasma KRunner plugin, i.e. offering some sort of feedback like "Search Google for blah" when a user enters something like "gg:blah" in the address bar ? I just want to make sure people really understand how to properly use KUriFilter...

Basically, yes. With some difference. Our "feedback" is a list of options. And... let me explain this with an example: with google as default engine & colon separator, you type wp:blah and search wikipedia for blah, you type wp blah and you search google for "wp blah". KRunner does not support feedback for this second option, while we'd like to.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4040/#review6084
-----------------------------------------------------------


On 2010-06-11 02:54:22, Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4040/
> -----------------------------------------------------------
> 
> (Updated 2010-06-11 02:54:22)
> 
> 
> Review request for kdelibs and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> The attached patch adds functionality to KUriFilter and its helper classes to make it possible to use it for only search related filtering. The intent of this patch is to correctly address the issue that caused applications/plugins to write their own implementation of web shortcut filters because of missing functionality in this class. This has led to behavioral differences between implementations, e.g. Konqueror's location bar vs KRunner. 
> 
> For further discussion of the issues, please refer to the following thread:
> 
> http://lists.kde.org/?t=127370544600008&r=1&w=2
> 
> 
> With this enhacement, KRunner can now obtain information it needs to show the user feedback such as "Search <provider-name> for <search-term>" where both <provider-name> and <search-term> are now made available by KUriFilterData. The enhancement also allows khtml and kwebkitpart to query for all the necessary information they need to display context menu "search" options on selected text instead of relying on the configuration information of a completely unrelated application (read: plugin) which can definitely be changed without notice!
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/runtime/kurifilter-plugins/fixhost/fixhosturifilter.cpp 1136838 
>   trunk/KDE/kdebase/runtime/kurifilter-plugins/ikws/kuriikwsfilter.cpp 1136838 
>   trunk/KDE/kdebase/runtime/kurifilter-plugins/ikws/kuriikwsfiltereng.h 1136838 
>   trunk/KDE/kdebase/runtime/kurifilter-plugins/ikws/kuriikwsfiltereng.cpp 1136838 
>   trunk/KDE/kdebase/runtime/kurifilter-plugins/ikws/kurisearchfilter.h 1136838 
>   trunk/KDE/kdebase/runtime/kurifilter-plugins/ikws/kurisearchfilter.cpp 1136838 
>   trunk/KDE/kdebase/runtime/kurifilter-plugins/localdomain/localdomainurifilter.cpp 1136838 
>   trunk/KDE/kdelibs/khtml/khtml_ext.cpp 1136838 
>   trunk/KDE/kdelibs/kio/kio/kurifilter.h 1136838 
>   trunk/KDE/kdelibs/kio/kio/kurifilter.cpp 1136838 
> 
> Diff: http://reviewboard.kde.org/r/4040/diff
> 
> 
> Testing
> -------
> 
> - Validated the kurifilter-plugin tests still pass.
> - Tested the code through KHTML/KWebKitPart's context menu that allows you to search for the selected text:
>    ** Validated functionality even when the user has not selected a default as well as faviorte search providers.
>    ** Validated functionality when only default search provider is configured.
>    ** Validated functionality when only favorite search providers are configured.
> 
> 
> Thanks,
> 
> Dawit
> 
>