Review Request: document KUniqueApplication::loadCommandLineOptionsForNewInstance and implement stub

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4278/#review6095
-----------------------------------------------------------


Rejected. You cannot add new virtual functions (the whole reason why the function is called as a slot in the first place).

The correct fix would be to check (via some QMeta* magic) if the slot actually exists on the object before invoking it.

- Christoph


On 2010-06-11 17:00:50, argonel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4278/
> -----------------------------------------------------------
> 
> (Updated 2010-06-11 17:00:50)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Adds a stub version of loadCommandLineOptionsForNewInstance to squelch the new warning in QT4.7.
> 
> 
> This addresses bug 241435.
>     https://bugs.kde.org/show_bug.cgi?id=241435
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdeui/kernel/kuniqueapplication.h 1128365 
> 
> Diff: http://reviewboard.kde.org/r/4278/diff
> 
> 
> Testing
> -------
> 
> I do not use qt4.7 at present..
> 
> 
> Thanks,
> 
> argonel
> 
>