Review Request: Patch to set SSL configuration information in KIO::AccessManagerReply...

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4239/
-----------------------------------------------------------

(Updated 2010-06-09 17:37:26.012907)


Review request for kdelibs.


Changes
-------

Updated patch to include a function for converting KIO SSL meta-data into QSslConfiguration.


Summary
-------

The attached patch adds a new metadata (ssl_cipher_name) to facilitate the creation and setting of SSL configuration information in KIO::AccessManagerReply. The new meta-data is needed for easily creating the appropriate QSslCipher object. 

Simply put the intent this patch is to make QNetworkReply::sslConfiguration() useful. Currently that function is completely useless. If you want to obtain SSL configuration information, you have to query the KIO meta-data through attribute function of this class. By translating the SSL information into the corresponding Qt related class, it will not only be simple to access the information (do not have to look for the "ssl_" meta-datas), but also avoids code duplication at the client level.

Any objections to me commiting this for KDE 4.5 ?


Diffs (updated)
-----

  trunk/KDE/kdelibs/kio/DESIGN.metadata 1136101 
  trunk/KDE/kdelibs/kio/kio/accessmanager.h 1136101 
  trunk/KDE/kdelibs/kio/kio/accessmanager.cpp 1136101 
  trunk/KDE/kdelibs/kio/kio/accessmanagerreply_p.cpp 1136101 
  trunk/KDE/kdelibs/kio/kio/tcpslavebase.cpp 1136101 

Diff: http://reviewboard.kde.org/r/4239/diff


Testing
-------


Thanks,

Dawit