Review Request: KTimeZoneWidget: Display country name instead of country code.

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4247/#review6026
-----------------------------------------------------------


A distinct improvement! I notice that there are still a few country codes displayed, which KLocale presumably doesn't have names for. But your patch rightly IMO still displays the country code for want of anything better if there's no lookup.

- David


On 2010-06-06 22:20:31, John Layt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4247/
> -----------------------------------------------------------
> 
> (Updated 2010-06-06 22:20:31)
> 
> 
> Review request for kdelibs, David Jarvie and David Faure.
> 
> 
> Summary
> -------
> 
> The KTimeZoneWidget lists the city name and region name, but only the country code, which is not good usability as users may not know their country code, cannot search on their country name, and it is not always obvious what city is listed for their timezone.
> 
> 
> This addresses bug 151636.
>     https://bugs.kde.org/show_bug.cgi?id=151636
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/widgets/ktimezonewidget.cpp 1135123 
> 
> Diff: http://reviewboard.kde.org/r/4247/diff
> 
> 
> Testing
> -------
> 
> It compiles :-)  I tried testing but my 4.5 dev system won't load the zonetab.  Can someone please check for me, or point me to how to get the zonetab to load?
> 
> 
> Thanks,
> 
> John
> 
>