Review Request: When a source file for kconf_update does not exist, do not create it

Kevin Krammer kevin.krammer at
Mon Jun 7 11:15:46 BST 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-06-07 10:15:45.978577)

Review request for kdelibs.


Found another occurrence where "empty" configs would be created. Add check for file's existance to checkGotFile() as well


Currently, when kconf_update is being run by kdeinit4 on a new user account, it creates all config files that it has updates for, regardless whether these files exist.
Which mean .kde/share/config gets populated with a lot of files with only kconf_update's entry in them.

Unfortunately that means that programs checking for a specific file's existance, e.g. PIM apps which are checking whether to run a migrator tool, will be fooled into assuming that there are actually valid settings.

The patch uses the already set m_skipFile flag to decide when not to sync the KConfig object, thus not creating the file if it didn't exist before

Diffs (updated)

  /trunk/KDE/kdelibs/kconf_update/kconf_update.cpp 1135402 





More information about the kde-core-devel mailing list