Review Request: When a source file for kconf_update does not exist, do not create it

Kevin Krammer kevin.krammer at
Mon Jun 7 10:22:31 BST 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-06-07 09:22:31.362288)

Review request for kdelibs.


Thanks for the feedback.

- QFileInfo include move to the other Qt includes
- Skipping the config writing/syncing sections, keeping the deletes
- Using different log message
- Fixed intendation

The QFileInfo checks if the file is actually present in the user's config directory, the other check is based on merged content.
The QFileInfo check would not be necessary if the config object had been opened as SimpleConfig, but it hasn't.


Currently, when kconf_update is being run by kdeinit4 on a new user account, it creates all config files that it has updates for, regardless whether these files exist.
Which mean .kde/share/config gets populated with a lot of files with only kconf_update's entry in them.

Unfortunately that means that programs checking for a specific file's existance, e.g. PIM apps which are checking whether to run a migrator tool, will be fooled into assuming that there are actually valid settings.

The patch uses the already set m_skipFile flag to decide when not to sync the KConfig object, thus not creating the file if it didn't exist before

Diffs (updated)

  /trunk/KDE/kdelibs/kconf_update/kconf_update.cpp 1135402 





More information about the kde-core-devel mailing list