review request concerning KInfoCenter->summary page
David Hubner
hubnerd at ntlworld.com
Sat Jun 5 19:20:35 BST 2010
On Fri, 4 Jun 2010 12:29:08 -0600
Hugo Pereira Da Costa <hugo at oxygen-icons.org> wrote:
> Hello,
>
> I attended to submit this suggested patch to kde reviewboard, but did not find
> to which group/people I should assign it.
>
> It replaces the home-made round flat boxes in kinfocenter summary page by
> standard qgroupboxes. See screenshots at:
>
> current: http://www.flickr.com/photos/hugo-oxygen-icons-org/4669216175/
> patched: http://www.flickr.com/photos/hugo-oxygen-icons-org/4669839282/
>
> The patch applies to
> /trunk/KDE/kdebase/workspace/kinfocenter/Modules/infosummary
>
> In general, Nuno and I think that apps should try use 'standard' widgets as
> much as possible, rather than reimplementing their own, for consistency sake
> (inside a given style with respect to other elements, and also across
> applications).
>
> Side note: there is another review request in preparation that addresses the
> labels, but might break string freeze (softly)
>
> Comments (or instruction on where/to whom I should submit this at reviewboard)
> highly appreciated,
>
> Thanks !
>
> Hugo
Sysadmin have set up a kinfocenter group in reviewboard for me. Can you submit this to that group for me as i getting a large amount of patches for kinfocenter now kde is in beta1
Thanks
--
David Hubner <hubnerd at ntlworld.com>
More information about the kde-core-devel
mailing list