review request on kinfocenter/systemsettings tooltip appearance

Ben Cooksley sourtooth at
Sat Jun 5 03:36:10 BST 2010

On Sat, Jun 5, 2010 at 1:34 PM, Hugo Pereira Da Costa
<hugo at> wrote:
> Hello,
> This patch replaces the home-made horizontal separator in kinfocenter tooltips
> by a standard HLine frame, handled by the style, again, for consistency
> between apps.

Looks much nicer than my own written code. Thanks for the patch Hugo.

> Screenshots:
> current:
> suggested:
> The patch applies to
> /trunk/KDE/kdebase/workspace/kinfocenter/ToolTips
> Note: a similar patch should be also applied (if this one is accepted) to
> systemsettings' tooltips, which show the same custom "feature".
> (/trunk/KDE/kdebase/workspace/systemsettings/app/ToolTips)

Please feel free to commit this change to System Settings. ( where
this code originated )
The patch applied cleanly here.

> Comments (or instruction on where/to whom I should submit this at reviewboard)
> highly appreciated,
> Thanks !
> Hugo

System Settings Maintainer.

More information about the kde-core-devel mailing list