review request concerning KInfoCenter->summary page

Hugo Pereira Da Costa hugo at oxygen-icons.org
Fri Jun 4 19:29:08 BST 2010


Hello,

I attended to submit this suggested patch to kde reviewboard, but did not find 
to which group/people I should assign it.

It replaces the home-made round flat boxes in kinfocenter summary page by 
standard qgroupboxes. See screenshots at:

current: http://www.flickr.com/photos/hugo-oxygen-icons-org/4669216175/ 
patched: http://www.flickr.com/photos/hugo-oxygen-icons-org/4669839282/

The patch applies to 
/trunk/KDE/kdebase/workspace/kinfocenter/Modules/infosummary

In general, Nuno and I think that apps should try use 'standard' widgets as 
much as possible, rather than reimplementing their own, for consistency sake 
(inside a given style with respect to other elements, and also across 
applications). 

Side note: there is another review request in preparation that addresses the 
labels, but might break string freeze (softly)

Comments (or instruction on where/to whom I should submit this at reviewboard) 
highly appreciated,

Thanks !

Hugo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: defaultboxwidget.diff
Type: text/x-patch
Size: 850 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100604/5a3cddbb/attachment.bin>


More information about the kde-core-devel mailing list