Review Request: Workaround for non-thread-safety of QDBusConnection

[Sebastian Trüg]

On 05/31/2010 11:24 PM, Sune Vuorela wrote:
> On 2010-05-31, Sebastian Trüg <trueg at kde.org> wrote:
>> On 05/27/2010 04:23 PM, Thiago Macieira wrote:
>>> Note that there is a fix for the issue.
>>>
>>> I will apply it to libdbus-1. I recommend all distributions upgrade to D-Bus 
>>> 1.4.0 as soon as it's out (there's no schedule for it).
>>
>> Since this will most certainly not happen, how about patching this new
>> method into stable dbus and have QtDBus use it? It could be two
>> patchsets that distributions could apply until 1.4 becomes
>> "distribution-worthy".
> 
> isn't that basically a libdbus::setThreadSafety(bool b); api addition,
> defaulting to false?
> 
> for one reason or another, I kind of feel that it is bad api ...

it is bad api. That is why I am proposing to maintain it as a patch for
distributions only. Never to put it upstream.

Cheers,
Sebastian