Review Request: Ensure notifications sent to DBus notification daemons are compatible with that daemon's capabilities

[Sjors Gielen]

Op 27 jul 2010, om 19:55 heeft Olivier Goffart het volgende geschreven:

> Le Monday 26 July 2010, Sjors Gielen a écrit :
>> Op 25 jul 2010, om 19:35 heeft Sjors Gielen het volgende geschreven:
>>>> You can commit yourself.
>>>> Patch is good.
>>> 
>>> Committed, but annoyingly, I cancelled the commit to check one line
>>> again, but then svn suddenly committed with an incomplete log message.
>>> The first line of the log message should have been something like
>>> "Ensure notifications sent to DBus notification daemons are compatible
>>> with that daemon's capabilities" :-(
>>> 
>>> Oh well, the patch is in! On to implementing Growl support.
>>> 
>>> Thanks,
>>> Sjors
>> 
>> Hi Olivier, others,
>> 
>> I have committed this patch to trunk, but since it is quite a large and
>> important bugfix, I would love it to be in KDE 4.5 too. However, there are
>> risks in this patch, such as when applications do not send valid HTML (the
>> code takes it into consideration and it works in my tests, but still, it
>> is a risk).
>> 
>> Do you think it is OK to backport it to 4.5? Maybe in a simplified form?
> 
> I think this can indeed be backported.  
> Even if there is always a risk.
> The bug it fixes is important for users of kde applications on ubuntu/gnome

Thanks! Backported r1154518 to KDE 4.5 as r1155632. With even, finally, the right commit message ;-)

Sjors
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2214 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100727/ac9a07af/attachment.bin>