Review Request: KLocale - Move to fully private implementation

John Layt johnlayt at
Sun Jul 18 22:22:04 BST 2010

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs and David Faure.


Move KLocale to a fully private implementation model.  This is to enable the progressive implementation of separate private classes for Windows and Mac platforms that will override the base KDE implementation and directly access the host system locale functions while still using the KDE unique locale methods where necessary.

1) Separate the KLocalePrivate class out to own .h and .ccp files
2) Make all KLocalePrivate data members private, all access to be via virtual public methods
3) Move all method implementations into KLocalePrivate virtual methods
3) Make all KLocale methods point to KLocalePrivate methods only, no direct access to data members or implementation details
4) Create derived KLocaleWindowsPrivate and KLocaleMacPrivate classes

Most implementations are unchanged other than the minimum required, except those where Win/Mac specific code has been moved to the Win/Mac classes.

Particular attention should be taken of the copy ctor and assignment op which I'm not 100% on.

Note I did 'svn cp' the klocale.cpp to the klocaleprivate.cpp but not to the .h or the Win/Mac .h and .cpp as the diff just became too huge and difficult to read.


  /trunk/KDE/kdelibs/kdecore/CMakeLists.txt 1151073 
  /trunk/KDE/kdelibs/kdecore/localization/klocale.h 1151073 
  /trunk/KDE/kdelibs/kdecore/localization/klocale.cpp 1151073 
  /trunk/KDE/kdelibs/kdecore/localization/klocale.cpp 1151073 
  /trunk/KDE/kdelibs/kdecore/localization/klocalemacprivate.cpp PRE-CREATION 
  /trunk/KDE/kdelibs/kdecore/localization/klocalemacprivate_p.h PRE-CREATION 
  /trunk/KDE/kdelibs/kdecore/localization/klocaleprivate_p.h PRE-CREATION 
  /trunk/KDE/kdelibs/kdecore/localization/klocalewindowsprivate.cpp PRE-CREATION 
  /trunk/KDE/kdelibs/kdecore/localization/klocalewindowsprivate_p.h PRE-CREATION 



Ran lots of existing unit tests.  Not yet tested compile on Windows or Mac, will do that once review approved as it requires some work to set up.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list