Review Request: KDiskFreeSpaceInfo: report correct free space on filesystems where frsize != bsize

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4551/#review6576
-----------------------------------------------------------


Boy this stuff is confusing.

               unsigned long  f_bsize;    /* file system block size */
               unsigned long  f_frsize;   /* fragment size */
               fsblkcnt_t     f_blocks;   /* size of fs in f_frsize units */
               fsblkcnt_t     f_bfree;    /* # free blocks */
               fsblkcnt_t     f_bavail;   /* # free blocks for non-root */

For f_blocks it's explicitely said that f_frsize is the unit, but for f_bfree and f_bavail it's really not clear!
Has this been tested on Linux too?

- David


On 2010-07-08 18:44:00, Max Brazhnikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4551/
> -----------------------------------------------------------
> 
> (Updated 2010-07-08 18:44:00)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> bsize is eight times greater than frsize on FreeBSD with default ufs2 filesystem, therefore KDiskFreeSpaceInfo reports incorrect free space.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kio/kfile/kdiskfreespaceinfo.cpp 1147566 
> 
> Diff: http://reviewboard.kde.org/r/4551/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Max
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100715/7ab6f2b3/attachment.htm>