Review Request: KDiskFreeSpaceInfo: report correct free space on filesystems where frsize != bsize

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4551/#review6522
-----------------------------------------------------------

Ship it!


Looks fine to me. I am no expert but from my Google "research" and test on Linux this seems like the correct approach.

- Sebastian


On 2010-07-08 18:44:00, Max Brazhnikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4551/
> -----------------------------------------------------------
> 
> (Updated 2010-07-08 18:44:00)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> bsize is eight times greater than frsize on FreeBSD with default ufs2 filesystem, therefore KDiskFreeSpaceInfo reports incorrect free space.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kio/kfile/kdiskfreespaceinfo.cpp 1147566 
> 
> Diff: http://reviewboard.kde.org/r/4551/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Max
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100713/9c61c519/attachment.htm>