Review Request: kde4-config --version doesn't work as advertised

[Rex Dieter]

> On 2010-01-28 17:10:12, Aaron Seigo wrote:
> > if there is a use case for having just the version string, then this should go in.
> 
> Rex Dieter wrote:
>     Honestly, if we're talking about a change, the use-case I had it mind would be to provide the bare (numeric) version, soemthing like:
>     printf("%i.%i.%i\n", KDE_VERSION_MAJOR, KDE_VERSION_MINOR, KDE_VERSION_RELEASE);
>     instead.

Erg, maybe not, then the description of ki18n("Compiled in version string for KDE libraries") wouldn't match reality either. :(  nevermind.


- Rex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2745/#review3942
-----------------------------------------------------------


On 2010-01-28 00:10:38, Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2745/
> -----------------------------------------------------------
> 
> (Updated 2010-01-28 00:10:38)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Make a new option, tentatively, named --kde-version that does what --version was supposed to do.
> 
> See also,
> https://bugs.kde.org/224540
> 
> Either this, or just remove the useless code.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/kde-config.cpp 1081218 
> 
> Diff: http://reviewboard.kde.org/r/2745/diff
> 
> 
> Testing
> -------
> 
> build with patch, now get:
> 
> $ ./kde4-config --kde-version
> 4.3.95 (KDE 4.3.95 (KDE 4.4 RC2))
> 
> 
> Thanks,
> 
> Rex
> 
>