Review Request: SQLite version handling improvements (FindSqlite macro)

[Todd]

> On 2010-01-30 23:57:04, Jaroslaw Staniek wrote:
> > I also propose to backport the change to all kdelibs branches supported by koffice trunk, i.e. 4.4 and 4.3.

I don't think there will be any new releases of KDE 4.3 after 4.3.5, especially not with 4.4 coming out in a matter of weeks.  So backporting to 4.3 would most likely not be an option.


- Todd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2772/#review3988
-----------------------------------------------------------


On 2010-01-30 23:54:24, Jaroslaw Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2772/
> -----------------------------------------------------------
> 
> (Updated 2010-01-30 23:54:24)
> 
> 
> Review request for kdelibs and Alexander Neundorf.
> 
> 
> Summary
> -------
> 
> The feature set differs from version to version in case of SQLite. Distributions do not allow to install many versions of SQLite side-by-side, so applications that use SQLite without embedding its source code need to carefully check for features available. Otherwise, for example, the files modified with SQLite can loose silently backward compatibility. To make the version tracking easier, two input variables are used:
> 
> *  SQLITE_MIN_VERSION - e.g. "3.6.16", if defined, older SQLite versions will not be accepted
> *  SQLITE_RECOMMENDED_VERSION - "3.6.22", if defined, warning will be displayed for older SQLite versions
> 
> This way, checks can be performed earlier - at configure stage.
> In addition, version checking is independent of pkg-config tool, so it works on MS Windows in the same way as on Unices.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/cmake/modules/FindSqlite.cmake 1082620 
> 
> Diff: http://reviewboard.kde.org/r/2772/diff
> 
> 
> Testing
> -------
> 
> One of the main users of SQLite, KOffice's Kexi, configures and builds fine. Behaviour of the new script is backward-compatible.
> 
> 
> Thanks,
> 
> Jaroslaw
> 
>