[KDE Usability] Review Request: Add "Open File Manager" action to KFileDialog toolbar

Harsh J qwertymaniac at gmail.com
Sat Jan 30 23:33:54 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2757/
-----------------------------------------------------------

(Updated 2010-01-30 23:33:53.866225)


Review request for kdelibs, usability, Shaun Reich, and David Faure.


Changes
-------

I thought it'd be more visible that way, but alright -> moved the button to the context menu, right above the "Properties" button (added via KDirOperator::FileActions flag).

Addressed Peter's and Markus' comments.

[Offtopic: I'd also appreciate if someone (re)looked at the diff here: http://reviewboard.kde.org/r/2729/]


Summary
-------

Patch proposes to add a "Open File Manager" button (with system-file-manager icon) to the KFileDialog toolbar, alongside the inline preview button.

This will open the current Url the dialog is in, in the default file manager (via KRun).


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kfile/kdiroperator.h 1082235 
  /trunk/KDE/kdelibs/kfile/kdiroperator.cpp 1082235 

Diff: http://reviewboard.kde.org/r/2757/diff


Testing
-------

Works with any directory the dialog is currently viewing.


Screenshots
-----------

Open File Manager in Open File dialog toolbar
  http://reviewboard.kde.org/r/2757/s/307/


Thanks,

Harsh



More information about the kde-core-devel mailing list