Review Request: Add "Open File Manager" action to KFileDialog toolbar

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2757/#review3980
-----------------------------------------------------------


I'm wondering why you've put the "open in filemanager" action into the (IMO already crowded) toolbar instead of the context menu. My guess is that this action is rarely used and hence should stay out of the toolbar.

- Peter


On 2010-01-30 13:10:57, Harsh J wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2757/
> -----------------------------------------------------------
> 
> (Updated 2010-01-30 13:10:57)
> 
> 
> Review request for kdelibs, usability, Shaun Reich, and David Faure.
> 
> 
> Summary
> -------
> 
> Patch proposes to add a "Open File Manager" button (with system-file-manager icon) to the KFileDialog toolbar, alongside the inline preview button.
> 
> This will open the current Url the dialog is in, in the default file manager (via KRun).
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kfile/kdiroperator.h 1082235 
>   /trunk/KDE/kdelibs/kfile/kdiroperator.cpp 1082235 
>   /trunk/KDE/kdelibs/kfile/kfilewidget.cpp 1082235 
> 
> Diff: http://reviewboard.kde.org/r/2757/diff
> 
> 
> Testing
> -------
> 
> Works with any directory the dialog is currently viewing.
> 
> 
> Screenshots
> -----------
> 
> Open File Manager in Open File dialog toolbar
>   http://reviewboard.kde.org/r/2757/s/307/
> 
> 
> Thanks,
> 
> Harsh
> 
>