Review Request: Broken redirections in handling of webdav when server requests a redirection from http to https

[Matthew Dawson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2760/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

When a website holding a webdav repository automatically redirects all http requests to https, the webdav handler in kio_http forces the request back to http.  The problem occurs as the code assumes the webdav protocol will not change.

This patch fixes the issue by analyzing the returned url, and sets webdav/webdavs based on whether the server requested a redirection to http/https respectively.  It also includes a fallback to the old behaviour if no protocolis specified, or the protocol is not http/https (is that a legal request?  If not I can remove the fallback).

Also, is it ok to backport this patch for KDE SC 4.4?


Diffs
-----

  /trunk/KDE/kdelibs/kioslave/http/http.cpp 1082000 

Diff: http://reviewboard.kde.org/r/2760/diff


Testing
-------

Locally against a remote server running lighttpd the auto redirects all requests from http to https.  The webdav implementation used comes from webcit, included in the citadel mailserver.  Url was:

webdav://mail.mjdsystems.ca/groupdav .


Thanks,

Matthew