Review Request: Automatic AdBlock filter list updates in Konqueror

[Thomas Braxton]

> On 2009-11-30 23:10:31, David Faure wrote:
> > /trunk/KDE/kdebase/apps/konqueror/settings/konqhtml/filteropts.cpp, line 376
> > <http://reviewboard.kde.org/r/2265/diff/1/?file=14937#file14937line376>
> >
> >     NULL is the default value for toInt(), no need to write it explicitely.

Actually, KConfig handles ints.  So you can change "7" to just 7 and get rid of the toInt call completely. 


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2265/#review3352
-----------------------------------------------------------


On 2010-01-26 00:03:23, Thomas Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2265/
> -----------------------------------------------------------
> 
> (Updated 2010-01-26 00:03:23)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This is the patch from bug report 143495 slightly rewritten to fit KDE trunk (though not compiled as I am lacking Qt 4.6). The original patch was written for 4.2.4, later updated for 4.3.1. Please refer to the bug report in bugs.kde.org for a small history of this patch set.
> I wrote a blog entry explaining the background of this patch, too: http://blog.t-fischer.net/2009/08/05/automatic-adblock-filter-list-updates-in-konqueror/
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konqueror/settings/konqhtml/filteropts.h 1079192 
>   /trunk/KDE/kdebase/apps/konqueror/settings/konqhtml/filteropts.cpp 1079192 
>   /trunk/KDE/kdelibs/khtml/khtml_settings.h 1079192 
>   /trunk/KDE/kdelibs/khtml/khtml_settings.cpp 1079192 
> 
> Diff: http://reviewboard.kde.org/r/2265/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Configuration dialog for automatic filter lists
>   http://reviewboard.kde.org/r/2265/s/302/
> 
> 
> Thanks,
> 
> Thomas
> 
>