New KGraphicsSignalPlotter class

John Tapsell johnflux at
Fri Jan 29 04:28:27 GMT 2010

2010/1/29 Parker Coates <parker.coates at>:
> On Thu, Jan 28, 2010 at 02:49, John Tapsell wrote:
>>  I tried upload the code to reviewboard, but I can't get it to accept
>> git's diff format. :-/
> Use the following script to make ReviewBoard compatible diffs from Git:
> #!/bin/sh
> REV=`git svn find-rev $(git-rev-list --date-order --max-count=1 git-svn)`
> git diff --no-prefix $(git-rev-list --date-order --max-count=1 git-svn) $* |
> sed -e "s/^+++ .*/&\t(working copy)/" -e "s/^--- .*/&\t(revision $REV)/"
> I have no idea where the script came from; the original author really
> should have included a copyright line. :)

I tried that, but it failed for new files.  They end up looking like:

--- /dev/null (revision 12343)
+++ /kdebase/somenewfile

And then reviewboard complains that it can't find the file "/dev/null" ?


More information about the kde-core-devel mailing list