Review Request: Fix paint recursion in "three bullet" password echo mode

Christoph Feck christoph at maxiom.de
Fri Jan 29 01:07:01 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2758/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

I am not sure if all bugs are caused by the painting recursion, but they are all related to the "three bullet" password echo mode. As indicated in the diff, simply blocking signals does not prevent setText() calling update(), we have to force disabling updates the hard way, by setting a Qt flag, which is usually only modified internally by Qt.


This addresses bugs 180482, 186724, 211250, 215380, and 224693.
    https://bugs.kde.org/show_bug.cgi?id=180482
    https://bugs.kde.org/show_bug.cgi?id=186724
    https://bugs.kde.org/show_bug.cgi?id=211250
    https://bugs.kde.org/show_bug.cgi?id=215380
    https://bugs.kde.org/show_bug.cgi?id=224693


Diffs
-----

  /trunk/KDE/kdelibs/kdeui/widgets/klineedit.cpp 1081663 

Diff: http://reviewboard.kde.org/r/2758/diff


Testing
-------


Thanks,

Christoph





More information about the kde-core-devel mailing list